search

TritonDataCenter / node-sshpk

Parse, convert, fingerprint and use SSH keys in pure node.js
MIT License
189 stars 50 forks source link

Fix throwing on invalid fingerprints #47

Closed ChALkeR closed 10 months ago

ChALkeR commented 6 years ago

This makes tests pass on current Node.js versions.

The test in question is https://github.com/joyent/node-sshpk/blob/v1.14.0/test/fingerprint.js#L117-L120 — it fails on Node.js 8 and 9 without this patch.

This is alternative approach to #41 (which just changes the test for some reason).

codecov-io commented 6 years ago

Codecov Report

Merging #47 into master will decrease coverage by 0.12%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
- Coverage   86.16%   86.04%   -0.13%     
==========================================
  Files          24       24              
  Lines        3680     3682       +2     
==========================================
- Hits         3171     3168       -3     
- Misses        509      514       +5
Impacted Files Coverage Δ
lib/fingerprint.js 79.16% <100%> (-4.88%) :arrow_down:
lib/signature.js 88.4% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6edb37c...2bef475. Read the comment docs.

bahamat commented 10 months ago

Fixed in fe7c161a8efb2a89438af346b9508395fad23d81.