search

TritonDataCenter / node-sshpk

Parse, convert, fingerprint and use SSH keys in pure node.js
MIT License
189 stars 50 forks source link

#53 Options deps are NOT optional if it won't run without them #55

Closed factoidforrest closed 10 months ago

factoidforrest commented 6 years ago

this is causing failures with certain build systems that expect the packages to be, you know, optional.

codecov-io commented 6 years ago

Codecov Report

Merging #55 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #55   +/-   ##
=======================================
  Coverage   86.37%   86.37%           
=======================================
  Files          24       24           
  Lines        3750     3750           
=======================================
  Hits         3239     3239           
  Misses        511      511

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1088992...9c57dd9. Read the comment docs.

bahamat commented 10 months ago

Fixed in 026ef4764a55648dd15f45f7f14ff9da5d1fe2ad.