trentm commented 5 years ago

make check failure:

00:00:41.570  deps/jsstyle/jsstyle -f tools/jsstyle.conf lib/identity.js lib/formats/rfc4253.js lib/formats/pkcs1.js lib/formats/openssh-cert.js lib/formats/x509-pem.js lib/formats/dnssec.js lib/formats/auto.js lib/formats/putty.js lib/formats/pem.js lib/formats/ssh.js lib/formats/ssh-private.js lib/formats/x509.js lib/formats/pkcs8.js lib/ed-compat.js lib/utils.js lib/algs.js lib/key.js lib/private-key.js lib/certificate.js lib/errors.js lib/ssh-buffer.js lib/fingerprint.js lib/dhe.js lib/signature.js lib/index.js
00:00:41.570  Unescaped left brace in regex is illegal here in regex; marked by <-- HERE in m/\S{ <-- HERE / at deps/jsstyle/jsstyle line 666.
00:00:41.570  make: *** [tools/mk/Makefile.targ:183: check-jsstyle] Error 255

is that something you've seen before?

cburroughs commented 5 years ago

is that something you've seen before?

Hundreds of times :-( Probably fixed by #65

codecov-io commented 5 years ago

Codecov Report

Merging #64 into master will increase coverage by 0.02%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
+ Coverage   87.11%   87.14%   +0.02%     
==========================================
  Files          25       25              
  Lines        4013     4013              
==========================================
+ Hits         3496     3497       +1     
+ Misses        517      516       -1

Impacted Files	Coverage Δ
lib/signature.js	`88.94% <0%> (+0.48%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e97ab59...c5bb75e. Read the comment docs.

TritonDataCenter / node-sshpk

TRITON-1943 add Jenkinsfiles to Triton repositories #64

Codecov Report