search

TritonDataCenter / node-triton

Triton client tool and node.js library
57 stars 39 forks source link

Allow spaces in the SSH ControlPath #334

Open blackwood821 opened 1 year ago

blackwood821 commented 1 year ago

This addresses https://github.com/TritonDataCenter/node-triton/issues/240

bahamat commented 1 year ago

This looks good, but we'd like to see some testing cases with example output.

blackwood821 commented 1 year ago

@bahamat Here is what we were getting before my change:

C:\Users\Test User>triton ssh sandbox
command-line line 0: garbage at end of line; "User\\AppData\\Roaming\\Joyent\\Triton\\tmp\\nullSshControlPath"

And here is what we got after my change:

C:\Users\Test User>triton ssh sandbox
Warning: Permanently added '10.10.50.105' (ED25519) to the list of known hosts.

  ,---.                   |     ,---. ,---.
  `---. ,-.-. ,---. ,---. |---  |   | `---.  base-64-lts
      | | | | ,---| |     |     |   |     |  22.4.0
  `---' ` ' ' `---' `     `---' `---' `---'

[root@sandbox ~]#