search

TritonDataCenter / node-verror

Rich JavaScript errors
MIT License
1.18k stars 61 forks source link

Update test results for Node.js 4 #27

Closed tomhughes closed 8 years ago

tomhughes commented 8 years ago

Note that I don't suggest you merge this as is - it is merely to demonstrate the differences that occur in stack traces when using Node.js 4 to run the tests.

The basic problem is that as a result of https://codereview.chromium.org/21761002 any custom toString method on a subclass of Error is not honoured when building the first line of the stack trace, so a WError does not get the cause added, and an SError is reported as a VError.

Obviously any real fix would either need to allow either result, or would need to find another way to get the expected stack traces.

davepacheco commented 8 years ago

Thanks for the info. I'm not sure what we can reasonably do about this, though.

davepacheco commented 8 years ago

Closing because this should be resolved with #10. I ran the (updated) test suite with Node 0.10, 0.12, 4, and 6.