search

TritonDataCenter / node-verror

Rich JavaScript errors
MIT License
1.18k stars 61 forks source link

Update LICENSE #35

Closed edi9999 closed 8 years ago

edi9999 commented 8 years ago

This makes it clear that the License is indeed MIT.

After merging this, can you please publish a new version to npm ?

Thanks in advance !

davepacheco commented 8 years ago

The existing LICENSE file contains the MIT license, and the npm metadata already specifies that the license is MIT. I hope the intent is pretty clear, and it matches the GitHub guidelines. I'm reluctant to make the suggested change because the same pattern is used in dozens of repositories of mine and Joyent's and we have tools that verify the expected LICENSE file format.

edi9999 commented 8 years ago

Which tool are you using to verify the license ? The current released project is not being recognized automatically by https://github.com/iandotkelly/nlf , a tool to find out which licenses your dependencies have.

This commit fixes this.

I also personally think that it is good for projects to be explicit about the license they use, it is faster to see : this is "MIT License" than to read the license text, and compare it withlicense texts found on google.

The license text given by github when you choose MIT is : 

The MIT License (MIT)

Copyright (c) 2016 David Pacheco

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.

It contains the text "The MIT License"

davepacheco commented 8 years ago

Continuing this discussion under https://github.com/davepacheco/node-extsprintf/pull/10.