search

TritonDataCenter / node-verror

Rich JavaScript errors
MIT License
1.18k stars 61 forks source link

joyent/node-verror#63 Do not call sprintf with one argument #73

Closed joyent-automation closed 3 years ago

joyent-automation commented 4 years ago

joyent/node-verror#63 Do not call sprintf with one argument

Portions contributed by: David Pacheco dap@joyent.com

This PR was migrated-from-gerrit, https://cr.joyent.us/#/c/6608/. The raw archive of this CR is here. See MANTA-4594 for info on Joyent Eng's migration from Gerrit.

CR discussion

Patch Set 1 code comments
lib/verror.js#400 @joyent-automation

warning: variable is declared but never referenced: options

lib/verror.js#413 @joyent-automation

warning: trailing_comma

@davepacheco commented at 2019-07-16T19:04:41

Uploaded patch set 3: Commit message was updated.

@trentm commented at 2019-10-24T17:18:34

Patch Set 4: Commit message was updated.

trentm commented 4 years ago

testing notes

This passes make test. It also passes the @Netflix/nerror "perror.test.js" file when I drop this "lib/verror.js" into it:

$ ./node_modules/.bin/mocha -R spec --full-trace --no-exit --no-timeouts test/perror.test.js

  perror
    ✓ should create a PError
    ✓ should not allow multiple arguments

  2 passing (6ms)
trentm commented 4 years ago

confusion on the line 214 of the README

Good point. I'll update that.