search

TritonDataCenter / node-verror

Rich JavaScript errors
MIT License
1.18k stars 61 forks source link

Unable to use with react-native #88

Open danielyaa5 opened 2 years ago

danielyaa5 commented 2 years ago

Hello, I was unable to use this package with react-native and I love it so much I made some changes to get it to work. https://github.com/danielyaa5/verror-2

If this is something you'd consider incorporating I will create a PR.

bahamat commented 2 years ago

Hi, I think we'd certainly be interested in adding support, but the repo you referenced, not being a proper github fork and having no history from this repo makes it nearly impossible to evaluate.

As a first step, it would be good to add to this issue a brief description of why it doesn't work with react. Next, we'll need a github pull request citing this issue that adds the necessary support. You'll need to be sure to match code style and policies, and make sure that both make check and make test pass.

At that point, we can do a full code review, and make sure any final changes get made, and then we can merge.