search

TritonDataCenter / node-workflow

Task orchestration, creation and running using NodeJS
MIT License
456 stars 66 forks source link

! child.test did not exit without error, because child was killed by parent #129

Closed nopol closed 9 years ago

nopol commented 9 years ago

Also made it easier to write own backend with base-backend.js

kusor commented 9 years ago

@dpoellath thanks for all the work made on this stuff. Sorry if I haven't answered earlier, but such amount of code definitely needs a review before hitting the merge button ;-)

Would it be possible to split this pull request into different, related, commits and have several pull requests?.

I'm interested into merge most of the stuff you've added here but, for example, I don't like to re-rewrite again backend modules using Objects and inheritance. I already rewrote everything using closures and singletons instead of sub-classes for GH-90 and, since it seems that all the problems we were experiencing then are have been fixed for a while, I cannot see any reason other than personal preferences to bring all the OOP back.

At the other hand, I'd love to add all the documentation and fixed you've brought into your code. Has sense for you?.

Thanks again!.

nopol commented 9 years ago

@kusor Thank you for your feedback. I'll looking forward to get that merge with you handled. Normally I'm working with GIT on a local environment. So can you tell me, how to split this? I mean i only pull requested the first commit, the other 3 where added automatically. I wanted to split this for you in the first hand.

nopol commented 9 years ago

Just added little commit to make it possible to use own (without npm-module or path) backend in config.

kusor commented 9 years ago

@dpoellath I think you need to use feature branches as explained here, picking just one commit at time: http://stackoverflow.com/questions/5256021/send-a-pull-request-on-github-for-only-latest-commit

nopol commented 9 years ago

/fixed & closed