search

TritonDataCenter / pkgsrc

NetBSD/pkgsrc fork for our binary package repositories
https://pkgsrc.smartos.org/
133 stars 50 forks source link

got: build failure on macOS Big Slurp 11.4 #310

Closed rnkn closed 3 years ago

rnkn commented 3 years ago

Hello,

I'm sure you've heard of OpenBSD's got project 😉

I get a build failure on macOS 11.4, on commit aee7d89d72c5a4cd94e4f20b72c333d4775c0b98 (HEAD -> joyent/release/macos, joyent/joyent/release/macos)

It seems that the OpenBSD compat code is assuming a system version of sha.h?

$ bmake install
=> Bootstrap dependency digest>=20010302: found digest-20190127
=> Checksum SHA1 OK for got-0.48.tar.gz
=> Checksum RMD160 OK for got-0.48.tar.gz
=> Checksum SHA512 OK for got-0.48.tar.gz
===> Installing dependencies for got-0.48
=> Tool dependency nbpatch-[0-9]*: found nbpatch-20151107
=> Build dependency cwrappers>=20150314: found cwrappers-20180325
=> Full dependency ncursesw>=6.0: found ncursesw-6.2
===> Checking for vulnerabilities in got-0.48
===> Overriding tools for got-0.48
===> Extracting for got-0.48
===> Patching for got-0.48
=> Applying pkgsrc patches for got-0.48
/usr/bin/find /opt/pkgsrc/devel/got/work/got-0.48 -name '*.[cy]' -exec  /opt/pkg/bin/nawk '/^#include /{c += 1;}  c == 1 {  gsub("(^#include )", "#include \"openbsd-compat.h\"\n&", $0)  }  {print $0 > "{}.back"}  '  {} \;
/usr/bin/find /opt/pkgsrc/devel/got/work/got-0.48 -name '*.[cy]' -exec  cp {}.back {} \;
/bin/cp -r /opt/pkgsrc/devel/got/files/openbsd-compat /opt/pkgsrc/devel/got/work/got-0.48/
===> Creating toolchain wrappers for got-0.48
===> Configuring for got-0.48
===> Building for got-0.48
all ===> openbsd-compat
clang -pipe -Os -D_XOPEN_SOURCE_EXTENDED=1 -I/opt/pkg/include -I/opt/pkg/include/ncurses -I/opt/pkgsrc/devel/got/work/got-0.48/openbsd-compat -D_XOPEN_SOURCE_EXTENDED=1 -I/opt/pkg/include -I/opt/pkg/include/ncurses -DGOT_LIBEXECDIR=/opt/pkg/bin -DGOT_VERSION= -I/opt/pkgsrc/devel/got/work/got-0.48/openbsd-compat/../openbsd-compat -Wno-pointer-sign -Werror -Wall -Wstrict-prototypes -Wunused-variable   -D_XOPEN_SOURCE_EXTENDED=1 -I/opt/pkg/include -I/opt/pkg/include/ncurses -DGOT_LIBEXECDIR=/opt/pkg/bin -DGOT_VERSION= -c freezero.c
clang -pipe -Os -D_XOPEN_SOURCE_EXTENDED=1 -I/opt/pkg/include -I/opt/pkg/include/ncurses -I/opt/pkgsrc/devel/got/work/got-0.48/openbsd-compat -D_XOPEN_SOURCE_EXTENDED=1 -I/opt/pkg/include -I/opt/pkg/include/ncurses -DGOT_LIBEXECDIR=/opt/pkg/bin -DGOT_VERSION= -I/opt/pkgsrc/devel/got/work/got-0.48/openbsd-compat/../openbsd-compat -Wno-pointer-sign -Werror -Wall -Wstrict-prototypes -Wunused-variable   -D_XOPEN_SOURCE_EXTENDED=1 -I/opt/pkg/include -I/opt/pkg/include/ncurses -DGOT_LIBEXECDIR=/opt/pkg/bin -DGOT_VERSION= -c -fPIC -DPIC freezero.c -o freezero.so
clang -pipe -Os -D_XOPEN_SOURCE_EXTENDED=1 -I/opt/pkg/include -I/opt/pkg/include/ncurses -I/opt/pkgsrc/devel/got/work/got-0.48/openbsd-compat -D_XOPEN_SOURCE_EXTENDED=1 -I/opt/pkg/include -I/opt/pkg/include/ncurses -DGOT_LIBEXECDIR=/opt/pkg/bin -DGOT_VERSION= -I/opt/pkgsrc/devel/got/work/got-0.48/openbsd-compat/../openbsd-compat -Wno-pointer-sign -Werror -Wall -Wstrict-prototypes -Wunused-variable   -D_XOPEN_SOURCE_EXTENDED=1 -I/opt/pkg/include -I/opt/pkg/include/ncurses -DGOT_LIBEXECDIR=/opt/pkg/bin -DGOT_VERSION= -c getdtablecount.c
clang -pipe -Os -D_XOPEN_SOURCE_EXTENDED=1 -I/opt/pkg/include -I/opt/pkg/include/ncurses -I/opt/pkgsrc/devel/got/work/got-0.48/openbsd-compat -D_XOPEN_SOURCE_EXTENDED=1 -I/opt/pkg/include -I/opt/pkg/include/ncurses -DGOT_LIBEXECDIR=/opt/pkg/bin -DGOT_VERSION= -I/opt/pkgsrc/devel/got/work/got-0.48/openbsd-compat/../openbsd-compat -Wno-pointer-sign -Werror -Wall -Wstrict-prototypes -Wunused-variable   -D_XOPEN_SOURCE_EXTENDED=1 -I/opt/pkg/include -I/opt/pkg/include/ncurses -DGOT_LIBEXECDIR=/opt/pkg/bin -DGOT_VERSION= -c -fPIC -DPIC getdtablecount.c -o getdtablecount.so
clang -pipe -Os -D_XOPEN_SOURCE_EXTENDED=1 -I/opt/pkg/include -I/opt/pkg/include/ncurses -I/opt/pkgsrc/devel/got/work/got-0.48/openbsd-compat -D_XOPEN_SOURCE_EXTENDED=1 -I/opt/pkg/include -I/opt/pkg/include/ncurses -DGOT_LIBEXECDIR=/opt/pkg/bin -DGOT_VERSION= -I/opt/pkgsrc/devel/got/work/got-0.48/openbsd-compat/../openbsd-compat -Wno-pointer-sign -Werror -Wall -Wstrict-prototypes -Wunused-variable   -D_XOPEN_SOURCE_EXTENDED=1 -I/opt/pkg/include -I/opt/pkg/include/ncurses -DGOT_LIBEXECDIR=/opt/pkg/bin -DGOT_VERSION= -c imsg-buffer.c
clang -pipe -Os -D_XOPEN_SOURCE_EXTENDED=1 -I/opt/pkg/include -I/opt/pkg/include/ncurses -I/opt/pkgsrc/devel/got/work/got-0.48/openbsd-compat -D_XOPEN_SOURCE_EXTENDED=1 -I/opt/pkg/include -I/opt/pkg/include/ncurses -DGOT_LIBEXECDIR=/opt/pkg/bin -DGOT_VERSION= -I/opt/pkgsrc/devel/got/work/got-0.48/openbsd-compat/../openbsd-compat -Wno-pointer-sign -Werror -Wall -Wstrict-prototypes -Wunused-variable   -D_XOPEN_SOURCE_EXTENDED=1 -I/opt/pkg/include -I/opt/pkg/include/ncurses -DGOT_LIBEXECDIR=/opt/pkg/bin -DGOT_VERSION= -c -fPIC -DPIC imsg-buffer.c -o imsg-buffer.so
clang -pipe -Os -D_XOPEN_SOURCE_EXTENDED=1 -I/opt/pkg/include -I/opt/pkg/include/ncurses -I/opt/pkgsrc/devel/got/work/got-0.48/openbsd-compat -D_XOPEN_SOURCE_EXTENDED=1 -I/opt/pkg/include -I/opt/pkg/include/ncurses -DGOT_LIBEXECDIR=/opt/pkg/bin -DGOT_VERSION= -I/opt/pkgsrc/devel/got/work/got-0.48/openbsd-compat/../openbsd-compat -Wno-pointer-sign -Werror -Wall -Wstrict-prototypes -Wunused-variable   -D_XOPEN_SOURCE_EXTENDED=1 -I/opt/pkg/include -I/opt/pkg/include/ncurses -DGOT_LIBEXECDIR=/opt/pkg/bin -DGOT_VERSION= -c imsg.c
clang -pipe -Os -D_XOPEN_SOURCE_EXTENDED=1 -I/opt/pkg/include -I/opt/pkg/include/ncurses -I/opt/pkgsrc/devel/got/work/got-0.48/openbsd-compat -D_XOPEN_SOURCE_EXTENDED=1 -I/opt/pkg/include -I/opt/pkg/include/ncurses -DGOT_LIBEXECDIR=/opt/pkg/bin -DGOT_VERSION= -I/opt/pkgsrc/devel/got/work/got-0.48/openbsd-compat/../openbsd-compat -Wno-pointer-sign -Werror -Wall -Wstrict-prototypes -Wunused-variable   -D_XOPEN_SOURCE_EXTENDED=1 -I/opt/pkg/include -I/opt/pkg/include/ncurses -DGOT_LIBEXECDIR=/opt/pkg/bin -DGOT_VERSION= -c -fPIC -DPIC imsg.c -o imsg.so
clang -pipe -Os -D_XOPEN_SOURCE_EXTENDED=1 -I/opt/pkg/include -I/opt/pkg/include/ncurses -I/opt/pkgsrc/devel/got/work/got-0.48/openbsd-compat -D_XOPEN_SOURCE_EXTENDED=1 -I/opt/pkg/include -I/opt/pkg/include/ncurses -DGOT_LIBEXECDIR=/opt/pkg/bin -DGOT_VERSION= -I/opt/pkgsrc/devel/got/work/got-0.48/openbsd-compat/../openbsd-compat -Wno-pointer-sign -Werror -Wall -Wstrict-prototypes -Wunused-variable   -D_XOPEN_SOURCE_EXTENDED=1 -I/opt/pkg/include -I/opt/pkg/include/ncurses -DGOT_LIBEXECDIR=/opt/pkg/bin -DGOT_VERSION= -c open.c
clang -pipe -Os -D_XOPEN_SOURCE_EXTENDED=1 -I/opt/pkg/include -I/opt/pkg/include/ncurses -I/opt/pkgsrc/devel/got/work/got-0.48/openbsd-compat -D_XOPEN_SOURCE_EXTENDED=1 -I/opt/pkg/include -I/opt/pkg/include/ncurses -DGOT_LIBEXECDIR=/opt/pkg/bin -DGOT_VERSION= -I/opt/pkgsrc/devel/got/work/got-0.48/openbsd-compat/../openbsd-compat -Wno-pointer-sign -Werror -Wall -Wstrict-prototypes -Wunused-variable   -D_XOPEN_SOURCE_EXTENDED=1 -I/opt/pkg/include -I/opt/pkg/include/ncurses -DGOT_LIBEXECDIR=/opt/pkg/bin -DGOT_VERSION= -c -fPIC -DPIC open.c -o open.so
clang -pipe -Os -D_XOPEN_SOURCE_EXTENDED=1 -I/opt/pkg/include -I/opt/pkg/include/ncurses -I/opt/pkgsrc/devel/got/work/got-0.48/openbsd-compat -D_XOPEN_SOURCE_EXTENDED=1 -I/opt/pkg/include -I/opt/pkg/include/ncurses -DGOT_LIBEXECDIR=/opt/pkg/bin -DGOT_VERSION= -I/opt/pkgsrc/devel/got/work/got-0.48/openbsd-compat/../openbsd-compat -Wno-pointer-sign -Werror -Wall -Wstrict-prototypes -Wunused-variable   -D_XOPEN_SOURCE_EXTENDED=1 -I/opt/pkg/include -I/opt/pkg/include/ncurses -DGOT_LIBEXECDIR=/opt/pkg/bin -DGOT_VERSION= -c recallocarray.c
clang -pipe -Os -D_XOPEN_SOURCE_EXTENDED=1 -I/opt/pkg/include -I/opt/pkg/include/ncurses -I/opt/pkgsrc/devel/got/work/got-0.48/openbsd-compat -D_XOPEN_SOURCE_EXTENDED=1 -I/opt/pkg/include -I/opt/pkg/include/ncurses -DGOT_LIBEXECDIR=/opt/pkg/bin -DGOT_VERSION= -I/opt/pkgsrc/devel/got/work/got-0.48/openbsd-compat/../openbsd-compat -Wno-pointer-sign -Werror -Wall -Wstrict-prototypes -Wunused-variable   -D_XOPEN_SOURCE_EXTENDED=1 -I/opt/pkg/include -I/opt/pkg/include/ncurses -DGOT_LIBEXECDIR=/opt/pkg/bin -DGOT_VERSION= -c -fPIC -DPIC recallocarray.c -o recallocarray.so
building standard openbsd-compat library
ar -c -q libopenbsd-compat.a `NM=nm lorder freezero.o getdtablecount.o imsg.o imsg-buffer.o open.o recallocarray.o | tsort -q`
ranlib libopenbsd-compat.a
building shared object openbsd-compat library
ar -c -q libopenbsd-compat_pic.a `NM=nm lorder freezero.so getdtablecount.so imsg.so imsg-buffer.so open.so recallocarray.so | tsort -q`
ranlib libopenbsd-compat_pic.a
all ===> libexec
all ===> libexec/got-read-blob
clang -pipe -Os -D_XOPEN_SOURCE_EXTENDED=1 -I/opt/pkg/include -I/opt/pkg/include/ncurses -I/opt/pkgsrc/devel/got/work/got-0.48/libexec/got-read-blob/../../include -I/opt/pkgsrc/devel/got/work/got-0.48/libexec/got-read-blob/../../lib -DGOT_LIBEXECDIR=/opt/pkg/libexec -DGOT_VERSION=0.48 -I/opt/pkgsrc/devel/got/work/got-0.48/libexec/got-read-blob/../../openbsd-compat -Wno-pointer-sign   -I/opt/pkgsrc/devel/got/work/got-0.48/libexec/got-read-blob/../../include -I/opt/pkgsrc/devel/got/work/got-0.48/libexec/got-read-blob/../../lib -DGOT_LIBEXECDIR=/opt/pkg/libexec -DGOT_VERSION=0.48 -c got-read-blob.c
In file included from got-read-blob.c:30:
/opt/pkgsrc/devel/got/work/got-0.48/libexec/got-read-blob/../../openbsd-compat/sha1.h:4:10: fatal error: 'sha.h' file not found
#include <sha.h>
         ^~~~~~~
1 error generated.
*** Error code 1

Stop.
bmake[2]: stopped in /opt/pkgsrc/devel/got/work/got-0.48/libexec/got-read-blob
*** Error code 1

Stop.
bmake[1]: stopped in /opt/pkgsrc/devel/got/work/got-0.48/libexec
*** Error code 1

Stop.
bmake: stopped in /opt/pkgsrc/devel/got/work/got-0.48
*** Error code 1

Stop.
bmake[1]: stopped in /opt/pkgsrc/devel/got
*** Error code 1

Stop.
bmake: stopped in /opt/pkgsrc/devel/got
rnkn commented 3 years ago

Some possibly helpful info from #gameoftrees IRC:

<CyberTailor> it needs libmd
<rnkn> CyberTailor: sorry is that re the pkgsrc failure?
<CyberTailor> rnkn: yes, i suspect a missing dependency
<CyberTailor> it's in libc of NetBSD and OpenBSD but other systems need it as a separate library
rnkn commented 3 years ago

After consulting with #netbsd it seems okay to just address this on NetBSD gnats. I'll close this so we just have the one thread: http://gnats.netbsd.org/cgi-bin/query-pr-single.pl?number=56349