TritonDataCenter / pkgsrc

NetBSD/pkgsrc fork for our binary package repositories
https://pkgsrc.smartos.org/
131 stars 51 forks source link

LDFLAGS error in build of net/xymon #349

Closed drboone closed 1 year ago

drboone commented 1 year ago

The issue seems pretty simple, probably configure being more particular than it was previously about the difference between LDFLAGS and LIBS. Catch is I can't seem to find where the -lintl -liconv is getting added to LDFLAGS.

...
checking build system type... x86_64-pc-solaris2.11
checking host system type... x86_64-pc-solaris2.11
configure: using LDFLAGS: -L/opt/local/gcc12/lib/gcc/x86_64-sun-solaris2.11/12.2.0 -Wl,-R/opt/local/gcc12/lib/gcc/x86_64-sun-solaris2.11/12.2.0 -L/opt/local/lib -Wl,-R/opt/local/lib -L/usr/lib/amd64 -Wl,-R/usr/lib/amd64 -lintl -liconv
configure: LDFLAGS error: LDFLAGS may only be used to specify linker flags, not libraries. Use LIBS for: -lintl
configure: LDFLAGS error: LDFLAGS may only be used to specify linker flags, not libraries. Use LIBS for: -liconv
configure: error: Can not continue. Fix errors mentioned immediately above this line.
gmake[1]: *** [Makefile:67: c-ares/Makefile] Error 1
gmake[1]: Leaving directory '/home/pbulk/build/net/xymon/work/xymon-4.3.30/xymonnet'
gmake: *** [build/Makefile.rules:106: xymonnet-build] Error 2

(Log snippet from the buildlog at https://us-central.manta.mnx.io/pkgsrc/public/reports/trunk/x86_64/20221203.0904/xymon-4.3.30nb5/build.log)

jperkin commented 1 year ago

Thanks, I fixed this a while back in fdbd10f6534ebb0d0b380105b50a86cb4cb457c8.