lang/go does not set GOOS variable to "illumos"

TritonDataCenter / pkgsrc

NetBSD/pkgsrc fork for our binary package repositories

https://pkgsrc.smartos.org/

131 stars 51 forks source link

Closed bardo closed 1 year ago

bardo commented 1 year ago

Some Go packages fail to build due to the GOOS variable being unset, which makes Go default to a Solaris build:

go env | grep -E 'GO(ARCH|OS)'
GOARCH="amd64"
GOOS="solaris"

The illumos target was introduced with https://github.com/golang/go/issues/20603, and it should probably be set in lang/go/version.mk.

jperkin commented 1 year ago

Yeh I was working on this before the Christmas break, and it will be switched for the 2022Q4 release.

jperkin commented 1 year ago

2022Q4 included this change, and I merged it into trunk in https://github.com/NetBSD/pkgsrc/commit/428ecfe1486baa569db8744bb050428bd7a56951 once I was happy with the results.