TritonDataCenter / sdc-docker

Docker Engine for Triton
Mozilla Public License 2.0
182 stars 49 forks source link

In non-overlay network mode, allow selecting which network is "external" #23

Closed arekinath closed 9 years ago

arekinath commented 9 years ago

In particular, don't enforce that "external" must be on a nic_tag named "external". This makes sdc-docker easier to try out in pre-existing SDC deployments that don't have overlays enabled yet.

This can take in a metadata option, EXTERNAL_NET to choose a name other than "external" to look for when selecting the network for docker containers.

arekinath commented 9 years ago

Ah, sorry. Corrected to single quotes. I made the change initially on the actual docker zone here and forgot to keep the original to diff, so I put it back together by re-typing because it was so short. The double quotes snuck in on the way and I didn't re-run make check.