DOCKER-618: check for invalid cloudapi URL

TritonDataCenter / sdc-docker

Docker Engine for Triton

Mozilla Public License 2.0

183 stars 49 forks source link

Closed misterdjules closed 8 years ago

misterdjules commented 8 years ago

When an invalid cloudapi URL is entered, an error message is displayed and the user is prompted to enter another URL.

This uses bash arrays, I'm not sure if that's a problem since we explicitly mention bash in the shebang.

misterdjules commented 8 years ago

/cc @trentm

trentm commented 8 years ago

@misterdjules sdc-docker-setup.sh is meant to work for non-JPC standups. Does this break that?

misterdjules commented 8 years ago

@trentm Excellent point, updated this PR to use the CloudAPI /--ping endpoint instead.

trentm commented 8 years ago

@misterdjules You also changed the mode on tools/sdc-docker-setup.sh unintentionally?

trentm commented 8 years ago

Otherwise LGTM. Thanks!

misterdjules commented 8 years ago

@trentm Good catch for the changed mode, it wasn't intentional. Updated this PR to address all your comments, will land soon. Thank you!

misterdjules commented 8 years ago

Landed in d429d88d71aa819c2d965d4af4f58c0f7952eb99.