DOCKER-502 support the use of a sdc package for creating containers

TritonDataCenter / sdc-docker

Docker Engine for Triton

Mozilla Public License 2.0

183 stars 49 forks source link

DOCKER-502 support the use of a sdc package for creating containers #62

Closed joshwilsdon closed 8 years ago

joshwilsdon commented 8 years ago

This adds support for:

docker run --label com.joyent.package=<pkg> ...

where <pkg> can be:

a package name
a package UUID
the first 8 characters of the package UUID

it also adds support for:

docker ps --filter "label=com.joyent.package=<pkg>"

with the same set of possible values for <pkg>.

joshwilsdon commented 8 years ago

I've addressed feedback from @askfongjojo and @trentm with 82518d056ec1b5dde85bcfa81f9d09b2b3d98535, specifically:

added comments about why com.joyent.package is special both to docs and code
added package label to inspect output
documented order of evaluation
fixed + '(name=' + opts.specifiedPackage +'))';
created DOCKER-677 to address package exclusion problems
matched trent-style indentation
included PACKAGE_SELECTION_LABEL in error messages for invalid package

what remains at this point is addressing any additional feedback and adding some tests.

misterdjules commented 8 years ago

@joshwilsdon Left a few comments :)

joshwilsdon commented 8 years ago

@misterdjules I've pushed 3445743eb24fbc8087962b7d57d57e611704279a which I think addresses all your comments except the one about ldap-filter. And for that one I created DOCKER-688. Let me know if you think there's additional work that should be done here or one of my changes seems incorrect.

misterdjules commented 8 years ago

I left an additional question, but mostly for my own curiosity. Otherwise LGTM.