search

TritonDataCenter / sdc-docker

Docker Engine for Triton
Mozilla Public License 2.0
183 stars 49 forks source link

Cleanup Firewall Rules #64

Open cehoffman opened 8 years ago

cehoffman commented 8 years ago

I decided to take a stroll over to my firewall rules and noticed that I had quite a few from the numerous docker containers I had spun up and subsequently destroyed that had published ports. Since sdc-docker creates this rules, I think this is the right place to bring up that these rules should be garbage collected on container removal.

melloc commented 8 years ago

Hey @cehoffman , there's an issue open for this, NET-329. Once it's in, it'll take care of cleaning things up when machines get deleted.

cehoffman commented 8 years ago

@melloc, good to know. A consideration to be aware of of what NET-329 is trying to accomplish. Rules created with terraform are expected to be deleted by terraform on destruction. The triton-terraform tool will need to not throw an error if the rule is already gone on destruction.