search

TritonDataCenter / sdc-docker

Docker Engine for Triton
Mozilla Public License 2.0
182 stars 49 forks source link

DOCKER-793: First pass for NFS shared volumes #78

Closed misterdjules closed 7 years ago

misterdjules commented 8 years ago

As indicated by the title of this PR, this is a first pass so that we can enable experimental support for NFS shared volumes at least in COAL, and hopefully in nightly. There's a lot of naive assumptions that are in place and that will be addressed by follow-up changes, but the goal is really to get the ball rolling behind a feature flag. I would encourage reviewers to not focus on edge cases but rather on the overall design of how this experimental feature is implemented.

When the experimental feature that this PR provides is enabled, it depends on changes in several other repositories like node-sdc-clients, a new sdc-volapi repository, sdcadm, mountain-gorilla, etc. but they should essentially have no impact when the feature is disabled, which is the default.

Tests that have been added are written to pass when the experimental feature is disabled. Thus, these changes could land independently of the rest of the changes needed to support NFS shared volumes.

joshwilsdon commented 8 years ago

I read through this PR and I think overall it looks good. There were a few very minor issues I pointed out, but since I know you were more concerned with the overall structure / etc, I think this looks good.

misterdjules commented 8 years ago

@joshwilsdon Added 3 commits to this PR that I believe address all your comments.

joshwilsdon commented 8 years ago

lgtm

BlinkyStitt commented 7 years ago

This looks really handy. Is there a timeline for getting this merged in?

misterdjules commented 7 years ago

It was decided that the whole feature needed to be more robust across all impacted APIs in Triton before merging anything into master branches of any Triton repository. As a result, development for the support of shared NFS volumes has continued on feature branches named tritonnfs for all relevant Triton repositories.

One way to test this feature is to run the setup.sh script from the sdc-volapi repository. This will upgrade all the relevant services and tools in a given Triton DC with the images available in the experimental channel that are built from the tritonnfs branches of all the relevant repositories.

Moreover, given that the contribution process has changed from using GitHub to using our Gerrit service, I think it's time to close this PR.

Feel free to post more comments in here if you have more questions about the state of shared volumes support in Triton though, I should be able to answer them quickly.

Thank you for your interest and sorry for the confusion!