TritonDataCenter / sdc-imgapi

SDC internal API for managing OS images
Mozilla Public License 2.0
5 stars 18 forks source link

TRITON-2005 imgapi needs to stop using snaplinks #31

Closed trentm closed 4 years ago

trentm commented 4 years ago

There were a number of IMGAPI endpoints that would use snaplinks for moving image files around for those that were stored in Manta (non-admin-owned images in an IMGAPI configured to use a Manta). These have been changed to instead stream the file out and stream the file back into Manta at the wanted path.

The one exception to that change is ImportImage: This used to write a temporary object path (.../$uuid/file0.$req_id) and then get linked to its final location (.../$uuid/file0). Now, for MantaStorage, it just writes directly to the final location. Manta semantics are such that a failed partial write does not blow away an existing object alread at that location, which was the original reason for that temporary path write.

Endpoints affected by this change