search

TritonDataCenter / sdc-sapi

SDC Services API. It coordinates the configuration and deployment of SDC services.
Mozilla Public License 2.0
2 stars 9 forks source link

TRITON-1943 add Jenkinsfiles to Triton repositories #8

Closed cburroughs closed 5 years ago

cburroughs commented 5 years ago

Testing out those ACLs.

trentm commented 5 years ago

Testing out those ACLs.

Indeed it did not build this. However, it also didn't create a joyent-org/job/sdc-sapi job from which I can quickly/easily do a build. I've restarted a joyent-org org scan to see if it picks it up. I'll leave this PR alive until I have a chance to play with that.

trentm commented 5 years ago

21:44:57 GitHub API Usage: Current quota has 3676 remaining (323 over budget). Next quota of 5000 in 59 min. Sleeping for 5 min 35 sec.

Oh boy, this is going to take a while.

trentm commented 5 years ago

Well, it got there for sdc-sapi, but:

  Checking pull-requests...

    Checking pull request #8
    (not from a trusted source)
      ‘Jenkinsfile’ not found
    Does not meet criteria

Hrm. I guess that "Jenkinsfile not found" is because "(not from a trusted source)". I guess if "automatic creation of the PR jenkins job from outside contributors" doesn't work for repos for which we don't already have such a job, isn't the end of the world.

trentm commented 5 years ago

Screenshot 2019-10-24 16 25 21

✅

cburroughs commented 5 years ago

I guess if "automatic creation of the PR jenkins job from outside contributors" doesn't work for repos for which we don't already have such a job, isn't the end of the world.

ah, I guess that's a consequence of the "trusted Jenkinsfiles" model. It doesn't trust changes, or creation. Which apart from the confusing use of the word "trust" sounds reasonably consistent.