OS-8316 vminfod client shouldn't attempt to cleanup on a ready timeout

TritonDataCenter / smartos-live

For more information, please see http://smartos.org/ For any questions that aren't answered there, please join the SmartOS discussion list: https://smartos.topicbox.com/groups/smartos-discuss

1.56k stars 244 forks source link

OS-8316 vminfod client shouldn't attempt to cleanup on a ready timeout #1001

Closed papertigers closed 2 years ago

papertigers commented 2 years ago

Turns out _abort() calls stop() which calls _clearReadyTimeout().
So I am opting for sticking on an additional property so that its easy to find with mdb.

papertigers commented 2 years ago

cc @bahamas10 if you have time and wouldn't mind looking this over.

bahamas10 commented 2 years ago

this change looks good to me! i like the idea. one small nit: initialize self.vs_ready_timeout_fired = false when the object is created so it always exists. otherwise, LGTM

danmcd commented 2 years ago

Please update the bug report with testing done, and your recent analysis to change the approach mentioned above in this PR.