TritonDataCenter / smartos-live

For more information, please see http://smartos.org/ For any questions that aren't answered there, please join the SmartOS discussion list: https://smartos.topicbox.com/groups/smartos-discuss
1.56k stars 244 forks source link

control+c kills "screen" #1017

Closed jcea closed 2 years ago

jcea commented 2 years ago

Control+c kills "screen" instead of killing the program running in a "screen" window.

Details in https://smartos.topicbox.com/groups/smartos-discuss/T0c7b4db6ca43415c-M9d889457c12a4a4e400c02c7/controlc-in-platform-screen-kills-current-window-instead-of-killing-the-program-running-inside

jcea commented 2 years ago

It affects 20220224. My previous platform, 20190829, it worked fine. I have not tried to locate the exact platform where this bug was introduced.

bahamat commented 2 years ago

Filed internally as OS-8364.

danmcd commented 2 years ago

This issue technically belongs in joyent/illumos-extra . Having said that, this fix works in a simple test case:

commit 95f08100857a910874d3d16713089235a14f74e7 (HEAD -> master)
Author: Dan McDonald <danmcd@joyent.com>
Date:   Thu Mar 17 10:02:23 2022 -0400

    OS-xxxx screen broken since illumos#12306

diff --git a/screen/Makefile b/screen/Makefile
index 9a09f6d..9f4a51f 100644
--- a/screen/Makefile
+++ b/screen/Makefile
@@ -18,7 +18,7 @@
 #
 # CDDL HEADER END
 #
-# Copyright 2021 Joyent, Inc.
+# Copyright 2022 Joyent, Inc.
 #

 VER =  screen-4.8.0
@@ -38,7 +38,7 @@ PATCHES =     Patches/*
 # while running configure (OS-8171).
 #
 AUTOCONF_ENV += \
-       CFLAGS="-std=c99 -D_XOPEN_SOURCE=700" \
+       CFLAGS="-std=c99 -D_XOPEN_SOURCE=700 -D__EXTENSIONS__=1" \
        LD_LIBRARY_PATH=$(DESTDIR)/usr/lib

 #