TritonDataCenter / smartos-live

For more information, please see http://smartos.org/ For any questions that aren't answered there, please join the SmartOS discussion list: https://smartos.topicbox.com/groups/smartos-discuss
1.57k stars 245 forks source link

Add support for add_datasets, remove_datasets to vmadm #904

Open sjorge opened 4 years ago

sjorge commented 4 years ago

Since we can now use sharesmb and sharenfs inside zones, it might be useful to make it easier to add datasets to zones.

Well, for standalone smartos at least. A while back a fix was added that no longer destroy the datasets delegated to a zone unless they are under the dataset that holds the zoneroot.

So it should now be safe to implement these. update_datasets makes no sense, given it add or remove.

@jlevon I'm willing to give this a go, as I have been inside vmadm recently so hopefully I will be able to manage this. Is this something that would have a chance of being merged?