TOOLS-2454 jenkins-joylib should allow mm notification comments

TritonDataCenter / smartos-live

For more information, please see http://smartos.org/ For any questions that aren't answered there, please join the SmartOS discussion list: https://smartos.topicbox.com/groups/smartos-discuss

1.57k stars 245 forks source link

TOOLS-2454 jenkins-joylib should allow mm notification comments #921

Closed timfoster closed 4 years ago

timfoster commented 4 years ago

I'm in two minds as to whether we should drop the 'os' notification for 'pipeline complete' That'll be relatively noisy for the os channel, as it'll include every PR update notification (specifically, each 'check' run will have one of these). Any strong opinions either way?

jlevon commented 4 years ago

I don't think it's a big deal personally, there's not that much building going on

timfoster commented 4 years ago

Added bahamat, to seek IA on this change once it has built.