TritonDataCenter / smartos-live

For more information, please see http://smartos.org/ For any questions that aren't answered there, please join the SmartOS discussion list: https://smartos.topicbox.com/groups/smartos-discuss
1.57k stars 246 forks source link

/etc/resolv.conf doesn't get populated if dns_domain is empty #948

Open quanah opened 4 years ago

quanah commented 4 years ago

There is no requirement for a dns domain to be populated, however if one is not defined in /usbkey/config, the smartos hypervisor fails to populate /etc/resolv.conf breaking name resolution within the hypervisor. i.e.:

....
dns_resolvers=8.8.8.8
dns_domain=""

results in a broken system. This appears to be due to a bug in /lib/svc/method/net-physical, where it checks for:

if [[ -n ${CONFIG_dns_domain} ]] && [[ -n ${CONFIG_dns_resolvers} ]]; then