search

TritonDataCenter / smartos-live

For more information, please see http://smartos.org/ For any questions that aren't answered there, please join the SmartOS discussion list: https://smartos.topicbox.com/groups/smartos-discuss
1.57k stars 246 forks source link

cannot support reprovision with non-standard "zones/data/smtest" dataset #972

Open sjorge opened 3 years ago

sjorge commented 3 years ago 
[root@boron ~]# echo '{"image_uuid": "2d8225e4-11e8-11eb-903a-c7c8880e45de"}' | vmadm reprovision 421330fc-5325-cb18-b42a-ab2c194c479f
Failed to reprovision VM 421330fc-5325-cb18-b42a-ab2c194c479f: cannot support reprovision with non-standard "zones/data/smtest" dataset

This might be the result of some work done to allow datasets to be added to zones for the nfs in zone server. Looks like it blocks reprovision, I don't think it should, external datasets no longer get destroyed when destorying a vm. So repsovision should also leave them intact and just do what it normally does.

sjorge commented 3 years ago

Retested, this is still the case. A dataset that is part of the zoneroot seems fine though.

so it’s only dataset outside of zoneroot, will try to remember that. As I keep thinking it’s all datasets.

bahamat commented 3 years ago

@sjorge So this is basically an enhancement request, since it currently operates as intended. My point of view on this would be that datasets owned by the zone should be under the zone root. That being the case, it's unlikely that we will ever implement this. However, if you or someone else implemented it and could demonstrate it working sufficiently well, I would not be opposed to merging it.