TritonDataCenter / smartos-live

For more information, please see http://smartos.org/ For any questions that aren't answered there, please join the SmartOS discussion list: https://smartos.topicbox.com/groups/smartos-discuss
1.57k stars 244 forks source link

Cannot update flexible_disk_size + add_disk in one payload #977

Open sjorge opened 3 years ago

sjorge commented 3 years ago
{
  "flexible_disk_size": 14592,
  "add_disks": [
    {
      "boot": false,
      "model": "virtio",
      "size": 4096
    }
  ]
}

The VM didn't have enough space, so I set the new flexible_disk_size in the same payload, this still doesn't work.

cannot create 'zones/e8bfab59-cc76-4dc0-af02-9c5f5c2f5e51/disk1': out of space

The entire update then stops, I assume it is doing the create of disk1 zvol before updating the zfs reservations with the new value of flexible_disk_size, but VM.js is a confusing beast.

Doing vmadm update $(vmadm lookup hostname=bhyvetest) flexible_disk_size=14592 before doing the add_disks payload works fine. Which seem to indeed indicate that the ordering is somehow wrong internally when both are in the same payload.