search

TritonDataCenter / terraform-provider-triton

Terraform Joyent Triton provider
https://www.terraform.io/docs/providers/triton/
Mozilla Public License 2.0
15 stars 24 forks source link

resource/triton_machine: Fixing StateChangeConf issue with Creation #20

Closed stack72 closed 7 years ago

stack72 commented 7 years ago

In a lot of test-cases, I received a timeout when creating an machine:

=== RUN   TestAccTritonMachine_basic
--- FAIL: TestAccTritonMachine_basic (653.80s)
    testing.go:435: Step 0 error: Error applying: 1 error(s) occurred:

        * triton_machine.test: 1 error(s) occurred:

        * triton_machine.test: timeout while waiting for state to become 'running' (last state: 'provisioning', timeout: 10m0s)

AFAICT, this was because the StateChangeConf func was returning machineStateProvisioning by default - not the actual state. Therefore, Terraform wasn't actually always able to tell if it had reached the desired state. By returning inst.State rather than assuming it was provisioning, I was able to get a more consistent test run.

HTTP_PROXY=http://127.0.0.1:8888 make testacc TEST=./triton TESTARGS='-run=TestAccTritonMachine_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./triton -v -run=TestAccTritonMachine_basic -timeout 120m
=== RUN   TestAccTritonMachine_basic
--- PASS: TestAccTritonMachine_basic (88.36s)
PASS
ok      github.com/terraform-providers/terraform-provider-triton/triton 88.381s

//cc jen20 @sean-

jen20 commented 7 years ago

Nice catch, this change is definitely correct.

jwreagor commented 7 years ago

Very nice catch, that one slipped right by my recent change there. 😅