search

TritonDataCenter / terraform-provider-triton

Terraform Joyent Triton provider
https://www.terraform.io/docs/providers/triton/
Mozilla Public License 2.0
15 stars 24 forks source link

Ordering of resources #62

Closed stack72 closed 6 years ago

stack72 commented 7 years ago

This is dependent on #61 as it has the new resource included

jwreagor commented 6 years ago

Technically this includes #61 so we'll close that and review in full here.

stack72 commented 6 years ago

@cheapRoc documentation additon made as follows:

Snapshots are not usable with other instances; they are a point-in-time snapshot of the current instance. 
Snapshots can also only be taken of instances that are not of brand `kvm`.

This is taken from the API Docs - https://apidocs.joyent.com/cloudapi/#CreateMachineSnapshot

jwreagor commented 6 years ago

What about creating a machine from a snapshot, is there any way we can add that to Terraform as well? Is that bloat for this PR?

jwreagor commented 6 years ago

Snapshots are not usable with other instances

Nice, forgot that bit.

stack72 commented 6 years ago

@cheapRoc the creating of a machine from a snapshot will follow on, that needs to be added to triton_machine and will need refactoring in there

jwreagor commented 6 years ago

All acc tests passed...

*[stack72-ordering-of-resources]$ make testacc
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v  -timeout 120m -parallel=4
?       github.com/terraform-providers/terraform-provider-triton        [no test files]
=== RUN   TestAccTritonImage_basic
--- PASS: TestAccTritonImage_basic (2.26s)
=== RUN   TestAccTritonImage_mostRecent
--- PASS: TestAccTritonImage_mostRecent (2.16s)
=== RUN   TestAccTritonNetwork_basic
--- PASS: TestAccTritonNetwork_basic (3.88s)
=== RUN   TestAccTritonNetwork_notfound
--- PASS: TestAccTritonNetwork_notfound (0.66s)
=== RUN   TestProvider
--- PASS: TestProvider (0.00s)
=== RUN   TestProvider_impl
--- PASS: TestProvider_impl (0.00s)
=== RUN   TestAccTritonFabric_basic
--- PASS: TestAccTritonFabric_basic (21.41s)
=== RUN   TestAccTritonFirewallRule_basic
--- PASS: TestAccTritonFirewallRule_basic (4.68s)
=== RUN   TestAccTritonFirewallRule_update
--- PASS: TestAccTritonFirewallRule_update (8.48s)
=== RUN   TestAccTritonFirewallRule_enable
--- PASS: TestAccTritonFirewallRule_enable (7.79s)
=== RUN   TestAccTritonKey_basic
--- PASS: TestAccTritonKey_basic (34.30s)
=== RUN   TestAccTritonKey_noKeyName
--- PASS: TestAccTritonKey_noKeyName (15.12s)
=== RUN   TestAccTritonMachine_basic
--- PASS: TestAccTritonMachine_basic (91.31s)
=== RUN   TestAccTritonMachine_affinity
--- PASS: TestAccTritonMachine_affinity (76.20s)
=== RUN   TestAccTritonMachine_dns
--- PASS: TestAccTritonMachine_dns (209.38s)
=== RUN   TestAccTritonMachine_nic
--- PASS: TestAccTritonMachine_nic (217.36s)
=== RUN   TestAccTritonMachine_addNIC
--- PASS: TestAccTritonMachine_addNIC (476.61s)
=== RUN   TestAccTritonMachine_firewall
--- PASS: TestAccTritonMachine_firewall (268.92s)
=== RUN   TestAccTritonMachine_metadata
--- PASS: TestAccTritonMachine_metadata (312.95s)
=== RUN   TestAccTritonMachine_cns
--- PASS: TestAccTritonMachine_cns (207.24s)
=== RUN   TestAccTritonMachine_locality
--- PASS: TestAccTritonMachine_locality (336.80s)
=== RUN   TestAccTritonSnapshot_basic
--- PASS: TestAccTritonSnapshot_basic (88.98s)
=== RUN   TestAccTritonVLAN_basic
--- PASS: TestAccTritonVLAN_basic (4.69s)
=== RUN   TestAccTritonVLAN_update
--- PASS: TestAccTritonVLAN_update (8.93s)
PASS
ok      github.com/terraform-providers/terraform-provider-triton/triton 2400.141s