Key lookup negation error causes cmon to fail all auth attempts

TritonDataCenter / triton-cmon

The Metric Agent Proxy for Triton's Container Monitor https://github.com/joyent/rfd/blob/master/rfd/0027/README.md

Mozilla Public License 2.0

6 stars 12 forks source link

Closed bahamat closed 3 years ago

bahamat commented 3 years ago

A missing negation in an if clause from cf56254 is causing CMON to fail all auth attempts.

-            } else if (!acct.account.keys || !acct.account.keys[keyId]) {
+            } else if (!acct.account.keys || acct.account.keys[keyId]) {

The first line is correct, the second is incorrect.

bahamat commented 3 years ago

Tested this by hot patching manually, and by installing the Jenkins PR-31-20210618T040115Z-g7501aaa image. Both fixes the issue.