search

TritonDataCenter / triton-kubernetes

Kubernetes on Triton
Mozilla Public License 2.0
183 stars 43 forks source link

Docker install script fails #142

Open darendarrow opened 6 years ago

darendarrow commented 6 years ago

I've noticed when deploying on Triton to an Ubuntu 17.10 20180222 image the script to install Docker fails. From what I see the script to install Docker uses apt.dockerproject.org; however, that has not been updated in some time.

$ curl https://apt.dockerproject.org/repo/dists/ubuntu-xenial/main/binary-amd64/Packages 2>&1 | grep Version | sort Version: 1.11.0-0~xenial Version: 1.11.1-0~xenial Version: 1.11.2-0~xenial Version: 1.12.0-0~xenial Version: 1.12.1-0~xenial Version: 1.12.2-0~xenial Version: 1.12.3-0~xenial Version: 1.12.4-0~ubuntu-xenial Version: 1.12.5-0~ubuntu-xenial Version: 1.12.6-0~ubuntu-xenial Version: 1.13.0-0~ubuntu-xenial Version: 1.13.1-0~ubuntu-xenial Version: 17.03.0~ce-0~ubuntu-xenial Version: 17.03.1~ce-0~ubuntu-xenial Version: 17.04.0~ce-0~ubuntu-xenial Version: 17.05.0~ce-0~ubuntu-xenial

The current version is 18.06.0~ce~3-0~ubuntu. The script should be modified to pull from download.docker.com, as this one from Docker does (but edited to use the stable branch), to build the repo file. That will ensure longterm compatibility and latest Docker versions.

Example install with modified script to install stable branch.

curl https://us-east.manta.joyent.com/daren.darrow@joyent.com/public/get-docker.sh | sudo bash

fayazg commented 5 years ago

This is a good idea but have to keep in mind supported docker versions that works with both Rancher and Kubernetes versions included.

darendarrow commented 5 years ago

Since it appears that Rancher keeps a modified version of the get script for each supported version, the wrapper should select the version based on the OS version or other selector and not depend on just the 17.0.3.sh version.

The options are in the Install scripts column on https://rancher.com/docs/rancher/v1.6/en/hosts/#supported-docker-version but they're named in a way that would usable programmatically.

darendarrow commented 5 years ago

I should note that the docs we're referencing is for Rancher v1.6. For version 2, the supported Docker versions are much simpler. For RHEL and Debian-based anything 17.03.2 or better is supported. https://rancher.com/docs/rancher/v2.x/en/installation/requirements/

oninoshiko commented 5 years ago

it would be convenient if this where fixed. It kinda sucks having to go into the rancher instance and manually run the script's commands to get it working