search

TritonDataCenter / triton

Triton DataCenter: a cloud management platform with first class support for containers.
https://www.tritondatacenter.com/
Mozilla Public License 2.0
1.31k stars 181 forks source link

TOOLS-2392 node-contract should not be an ignored jr-manifest.json entry #268

Closed timfoster closed 4 years ago

timfoster commented 4 years ago

As mentioned in the bug report, if there's a way to look for other repositories that might have the same issue, I'd be happy to update the PR with those repos.

I did do a hound search for "illumos_" but only node-contract matches:

https://hound.joyent.us/?q=require%5C(%27illumos_&i=nope&files=&repos=

timfoster commented 4 years ago

We'll move this to manta.git and address the other suggestions in the ticket.

timfoster commented 4 years ago

Reopening, since we need to remove node-contract from the ignore list here and move it to manta.git

timfoster commented 4 years ago

Trent mentioned on chat that the ignore list is there to say that the ignored repositories aren't relevant for this manifest, not ignored across all combined jr-manifests that we know about. As such, this PR and the smartos-live ones should be closed.