TritonVM / tasm-lib

A collection of functions written in Triton VM assembly (tasm)
Apache License 2.0
11 stars 2 forks source link

Add negative test and possibly rename `add_u128` #108

Closed Sword-Smith closed 2 months ago

Sword-Smith commented 2 months ago

This snippet asserts that there is no overflow. So maybe we should rename it to safe_add_u128?

We certainly need some negative tests to check that the VM crashes on overflow. safe_mul_u128 has very thorough negative tests that could be used as inspiration.