search

TritonVM / triton-vm

Triton is a virtual machine that comes with Algebraic Execution Tables (AET) and Arithmetic Intermediate Representations (AIR) for use in combination with a STARK proof system.
https://triton-vm.org
Apache License 2.0
241 stars 36 forks source link

Windows test build broken since 938db3eb? #244

Closed Sword-Smith closed 8 months ago

Sword-Smith commented 8 months ago

cargo build seems to work on Windows on current master, 63a5d1c110307dab73e28e5bb5a4187e2762b69f as of this issue. But ever since 938db3ebc3cc36da6ea7830036188ed61ba2d17f cargo test has not worked on Windows.

The problematic packages seem to be rexpect and pty-process, not sure how the latter one gets included though.

Should Windows builds and tests be added to CI?

aszepieniec commented 8 months ago

Should Windows builds and tests be added to CI?

If possible, yes.

jan-ferdinand commented 8 months ago

Both of the mentioned dependencies are from Triton TUI and are used exclusively in integration tests.[^1] We can make compilation of the integration tests conditional on the target platform.

[^1]: Those tests are currently ignored because they do not play ball with cargo tarpaulin, the code coverage tool we use.