TritonVM / triton-vm

Triton is a virtual machine that comes with Algebraic Execution Tables (AET) and Arithmetic Intermediate Representations (AIR) for use in combination with a STARK proof system.
https://triton-vm.org
Apache License 2.0
241 stars 36 forks source link

`payload_type` does not evaluate its constants #249

Closed Sword-Smith closed 6 months ago

Sword-Smith commented 7 months ago
ProofItemVariant::OutOfDomainQuotientSegments.payload_type()

returns the string [XFieldElement; NUM_QUOTIENT_SEGMENTS] instead of [XFieldElement; 4]. Would it be possible to return the value of constants instead of the names of the constants?

Sword-Smith commented 7 months ago

And the NUM_QUOTIENT_SEGMENTS constant is private to this repo, so I can't get its value from here :)

jan-ferdinand commented 7 months ago

Quick workaround: TARGET_AIR_DEGREE is always the same value, but of a different type. I'll look at this again to do it properly. :+1:

jan-ferdinand commented 6 months ago

The constant NUM_QUOTIENT_SEGMENTS is public as of Triton VM v0.37.0. Does that solve the issue?

Sword-Smith commented 6 months ago

The constant NUM_QUOTIENT_SEGMENTS is public as of Triton VM v0.37.0. Does that solve the issue?

Yes :)