Drop Duplicate Consts - Githubissues

TritonVM / triton-vm

Triton is a virtual machine that comes with Algebraic Execution Tables (AET) and Arithmetic Intermediate Representations (AIR) for use in combination with a STARK proof system.

https://triton-vm.org

Apache License 2.0

247 stars 37 forks source link

Drop Duplicate Consts #298

Closed aszepieniec closed 2 months ago

aszepieniec commented 5 months ago

The *BaseTableColumn and *ExtTableColumn structs define two consts indicating the number of columns: BASE_WIDTH (respectively EXT_WIDTH) and COUNT. The latter one is automatically derived via strum.

Having multiple consts referring to the same value is prone to error.

[ ] refactor: Drop duplicate width indicator from column structs

jan-ferdinand commented 2 months ago

Completed as of f594167d803d0b4fad0be95507bca329bad54cef.