Trixarian / NetherSX2-patch

Unofficial Patches for NetherSX2
https://discord.gg/6cGWCrqAw5
The Unlicense
635 stars 28 forks source link

Issues with the bash script #49

Closed SweatyNuN closed 3 months ago

SweatyNuN commented 4 months ago

Hiya, noticed your bash script has some small issues. First the chmod command on line 53 has the +x in the wrong place change it to:

chmod +x $p2f/lib/xdelta3

The curl download also seems to fetch a 0 byte file, for downloading its much better to use wget and most people will have that so line 65 can be changed to:

wget -P "$input_path" -q "https://github.com/Trixarian/NetherSX2-patch/releases/download/0.0/15210-v1.5-4248.apk"

I'd make a PR but I'm really lazy, hope this helps!

parkerlreed commented 3 months ago

curl works with -L to follow redirects

-L was added https://github.com/Trixarian/NetherSX2-patch/blob/main/builder/build-nethersx2.sh#L65

But -x for chmod is still in the wrong place https://github.com/Trixarian/NetherSX2-patch/blob/main/builder/build-nethersx2.sh#L53