Trixarian / NetherSX2-patch

Unofficial Patches for NetherSX2
https://discord.gg/6cGWCrqAw5
The Unlicense
910 stars 40 forks source link

New feature request: toggle lock fps #64

Open RomzesRover opened 6 months ago

RomzesRover commented 6 months ago

In original pcsx2 there is a useful feature for toggling fps limit exist. In current android version we also have the ability to switch it by editing config file. Somewhere here: Android/data/xyz.aethersx2.android/files/gamesettings/xxxx.ini Parameters called

[EmuCore/GS]
FramerateNTSC = 30.00
FrameratePAL = 30.00

That text will set fps lock to 30 either for ntsc or pal.

So, there is a proposition to add fps lock toggle to game menu, so there would be not needed to modify config manually. It will be also good for newer android version phones, because we don't have access to Android/data/ without root. You can hide it under Advanced Settings if you think some users would misunderstand the feature. I propose the next list 20,25,30,35,40,45,50,55,60, default (no lock).

This workaround works good for the need for speed game series, and all other where timers are not linked to the fps.

RomzesRover commented 6 months ago

I saw one mod with this feature long time ago on forum. So it should be an ability to make it. Hope to see this also in current the version.

RomzesRover commented 6 months ago

232323 5321293866919388117_121 I found that version and make some screenshots.

Saramagrean commented 6 months ago

Fixed value may safer?

ZomboDroid_22052024025115

tried to add this option in per-game setting (under system settings) and seem work fine. :)

Screenshot_20240522-145253_NetherSX2

RomzesRover commented 6 months ago

Fixed value may safer?

Good work and mod! Actually, when timings in game are not linked to fps there is no difference values are fixed or not. So user, can set up 40 fps if his phone able to work with it and has lags with 60fps. I think that it would be better to set any desired fps, instead of limited prebuilt list. In some games there is different fps in menu and in game itself. So you should apply patch for example for 60fps, and after that set limit to achieve same fps both in menu and game. If game does not have the 60fps patch and has different fpss in menu and game, you should set doubled limit to get desired fps in game itself. When timings in game are not linked to fps it is the best way to limit game instead of using "EE cycle thing". I hope you would read carefully, hope to this this functionality in next nethersx2 release. Can you please send your mod to nether to mee too? I would like to test.

Saramagrean commented 6 months ago

Can you please send your mod to nether to mee too? I would like to test.

Screenshot_20240522-234617_NetherSX2

here...

Trixarian commented 6 months ago

Well, this is interesting. Mind if I steal it? :P

Saramagrean commented 6 months ago

Just edit a few line in "res/xml/system_game_settings_preferences.xml" and "res/values/strings.xml". 😅 https://github.com/Saramagrean/NetherSX2-patch/commits/fps-control-settings/

RomzesRover commented 6 months ago

looks it works fine!

AriFanthomas commented 3 months ago

Can you please send your mod to nether to mee too? I would like to test.

Screenshot_20240522-234617_NetherSX2

here...

I cannot install this mod on my phone. I downloaded the mod, but cant install. I cant either edit the game setting file ini. I'm using galaxy S23 android 13.

I'm trying to lock 30 fps the nfs most wanted. The game requires a lot of the phone and I think if I lock the fps it will solve the problem.