TrixiEther / DashchanFork

Imageboards client for Android
GNU General Public License v3.0
40 stars 2 forks source link

Feature: autohide with empty values #133

Closed TrixiEther closed 8 months ago

TrixiEther commented 10 months ago

At the moment, it is not possible to configure auto-hide rules so that posts containing empty values can be hidden. If we try to leave the regular expression line empty, Dashchan hides everything.

I added custom rules for hiding based on empty values. When user select the appropriate item in the rules settings, the behavior will change automatically. In case of a rule, Dashchan will check if the value of title/comment/name/filename is not empty. The user can choose which values to perform checks in (I’m not sure if this is relevant for the name, since each module has a default name for anonymous, but I left this option)

N3-M3-S1S commented 10 months ago

@TrixiEther Looks like this regex works for hiding empty values:^$

TrixiEther commented 10 months ago

@N3-M3-S1S yeap, but I plan to release this method

N3-M3-S1S commented 10 months ago

@TrixiEther I'm not sure if this should be separate feature if it can be already achieved with a simple regex. As for code, it looks fine for the job it does.

TrixiEther commented 10 months ago

@N3-M3-S1S Perhaps in this case I will leave the check via regex ^$. But I want the interface to be more user friendly. Many users don't even know about this possibility.

N3-M3-S1S commented 10 months ago

@TrixiEther Regex is kind of advanced feature an if a user doesn't know about them he won't be able to use them anyway except very basic cases e.g. filtering single word / sentence. Perhaps more user-friendly approach is to make a help page with most popular regexes or just leave a link to some regex tutorial.