TrixiEther / DashchanFork

Imageboards client for Android
GNU General Public License v3.0
40 stars 2 forks source link

Attachment features #98

Closed TrixiEther closed 1 year ago

TrixiEther commented 1 year ago

Closes #87


Added a new posting item to the media settings, which allows to select automatic flags that will be set if possible immediately when attaching a file


Closes #82


When attaching a file, user can now select the "rename" function. When this checkbox is activated, when sending a file, it will be assigned a new name that the user enters himself or that has been configured in Preferences

Also in the settings allow to select an preconfigured name that will be assigned to all files, the "Rename" flag can also be automatically fixed for files

N3-M3-S1S commented 1 year ago

@TrixiEther I have some fixes, may i push them to this branch?

Also, there is a bug that i didn't fix: when the original file name contains special characters, pressing "restore filename" will clear the input instead of restoring file name because the input filter does not allow special characters. Do we need that input filter?

TrixiEther commented 1 year ago

@N3-M3-S1S let's look at the changes to begin with, how serious they are. I know about the file name problem, but I'm not sure if it's worth solving right now. I've never seen such filenames used with a bunch of special characters. Or I myself will add it later in one of the bug fixes

N3-M3-S1S commented 1 year ago

@TrixiEther Here is the list of bugs that i found and fixed:

And minor code changes:

TrixiEther commented 1 year ago

@N3-M3-S1S ok, let's merge that also

N3-M3-S1S commented 1 year ago

@TrixiEther Done.

TrixiEther commented 1 year ago

@N3-M3-S1S if you have created a separate button widget, it makes sense then to replace the code in the PostingFragment. This seems to have previously been the only place where a button of some sort was used... but right now it's not necessary

N3-M3-S1S commented 1 year ago

@TrixiEther Yeah, next time PostingFragment is modified the code for that button should be replaced with the class.