TrogloGeek / prestashop-tggatos-module

TggAtos Module for Prestashop (1.4 to 1.7), ATOS SIPS 6xx payment gateway
61 stars 34 forks source link

Bug - Support HTTPS protocol for Silent Return #92

Closed tups closed 5 years ago

tups commented 5 years ago

Support HTTPS protocol configuration for Silent Return : Get the Prestashop configuration for the HTTPS protocol (Generates a 302 if it types in HTTP on an HTTPS site)

TrogloGeek commented 5 years ago

Hi, thanks for submitting and sharing, but I cannot accept this pull requests as it breaks SIPS 600 specifications and will break silent response when bank servers are not HTTPS compatible (many were definitively not a few years ago, didn't check recently).

The module should indeed be updated to allow the use of HTTPS in silent response in case used SIPS servers are compatible with, but it should be done by adding a configuration key for it to be configurable the same way as user return. Not yet sure of what default value to be used, probably blank with a warning in back office to request the user to configure it, as with timezone, but not to break existing shops on module update, a blank value should still allow the gateway to be used and be treated as forced plain HTTP (so with a blank value, front office will continue working same way as before, while the back office would ask admin user to configure it, explaining that question about HTTPS support should be asked to bank tech support, and silent return should be tested after configuration has been set).

tups commented 5 years ago

( Désolé je reprends en francais :) ) Bonjour,

Je comprends, vous voulez l'ajouter directement en choix dans la configuration du module.

En tout cas, dans mon cas, ça posait un problème qu'il soit forcé en HTTP. Je prenais un 302 sur l'appel de la banque. Du coup je perdais les valeurs du POST.

En tout cas, merci pour votre réponse.


Hello,

I understand, you can add it directly in the module configuration.

In any case, in my case, it posed a problem that it is forced in HTTP. I make an appointment on the call of the bank. Suddenly I lost the values of POST.

In any case, thank you for your answer.