TronLink / tronlink-extension-core

Apache License 2.0
3 stars 5 forks source link

Inconsistent signing with Ledger wallet #11

Closed quentinadam closed 1 month ago

quentinadam commented 2 months ago

When signing typed data (TIP712) with the TronLink chrome extension the last byte (v) of the signature is inconsistent.

When signing using a local Tronlink private key, the last byte is between 27 and 30. When signing using a Ledger wallet connected to the tronlink extension, the last byte is between 0 and 3.

Can you please check as this seems inconsistent?

EllenWhitmore commented 1 month ago

For the TRON network, the last two digits of a TIP712 signature hash do not affect signature verification. Using the tronWeb.trx.verifyTypedData method to validate the hash of both types of signatures results in successful verification.