TronNatthakorn / react-native-wheel-pick

Apache License 2.0
177 stars 85 forks source link

build issue with version 1.2.2 import undefined.ReactNativeWheelPickerPackage; #39

Open rt012 opened 1 year ago

rt012 commented 1 year ago

with the version1 12.2 I get following error while building import undefined.ReactNativeWheelPickerPackage;

"react-native": "0.61.5",

L96Github commented 1 year ago

I have the same issue.


/Users/runner/work/1/s/android/app/build/generated/rncli/src/main/java/com/facebook/react/PackageList.java:87: error: package undefined does not exist
import undefined.ReactNativeWheelPickerPackage;
                ^
/Users/runner/work/1/s/android/app/build/generated/rncli/src/main/java/com/facebook/react/PackageList.java:169: error: cannot find symbol
      new ReactNativeWheelPickerPackage()
          ^
  symbol:   class ReactNativeWheelPickerPackage
  location: class com.facebook.react.PackageList
2 errors
solomen5555 commented 1 year ago

I have seem issue. "react-native-wheel-pick": "^1.1.0", "react-native": "0.61.5",

karimelsaidy commented 1 year ago

same here "react-native-wheel-pick": "^1.2.1", and "react-native-wheel-pick":"^1.2.2" also produce the same issue but version '^1.2.0' works fine "react-native" : "66.4"

sunilloharshoreline1 commented 1 year ago

same here "react-native-wheel-pick": "^1.2.1", and "react-native-wheel-pick":"^1.2.2" also produce the same issue but version '^1.2.0' works fine "react-native" : "66.4"

^1.2.0 doesnt work either.

Any other solution ?

ra30r commented 1 year ago

The issue seems to be this commit: https://github.com/TronNatthakorn/react-native-wheel-pick/commit/263fa97ab00062711617c02db447ee0ef37986df

Adding back the package name fixes the issue.

JJSLIoT commented 12 months ago

Following the changes mentioned by @ra30r I made this patch file:

name: react-native-wheel-pick+1.2.2.patch

diff --git a/node_modules/react-native-wheel-pick/android/src/main/AndroidManifest.xml b/node_modules/react-native-wheel-pick/android/src/main/AndroidManifest.xml
index a2f47b6..b45a8b6 100644
--- a/node_modules/react-native-wheel-pick/android/src/main/AndroidManifest.xml
+++ b/node_modules/react-native-wheel-pick/android/src/main/AndroidManifest.xml
@@ -1,2 +1,3 @@
-<manifest xmlns:android="http://schemas.android.com/apk/res/android">
+<manifest xmlns:android="http://schemas.android.com/apk/res/android"
+  package="com.tron">
 </manifest>
manishhedau commented 11 months ago

Hii everyone I am also facing the same issue while running react-native project in my system I am using the below versions

"react-native": "0.67.2", "react-native-wheel-pick": "^1.2.2"

if anyone has any solution for this issue please let us know

sunilloharshoreline1 commented 11 months ago

@manishhedau you will have to create a patch for the react-native-wheel-pick Change the manifest file from the following path : node_modules/react-native-wheel-pick/android/src/main/AndroidManifest.xml to this

<manifest xmlns:android="http://schemas.android.com/apk/res/android" package="com.tron">
</manifest>

it should work