search

Tronic / cmake-modules

LibFindMacros development repository and other cool CMake stuff
44 stars 17 forks source link

Fix wrong logic in process deps to add to #8

Closed hlouzada closed 1 year ago

hlouzada commented 1 year ago

Separate the include and lib check, and don't verify if plural form equals singular as there might be a case where both are defined. The expected behavior is to disregard the plural form and consider only the singular.

hlouzada commented 1 year ago

@Tronic Also bumped the version :rocket: Hope you can consider this PR.

Tronic commented 1 year ago

Seems reasonable but still needs some testing, not to break existing stuff.

Tronic commented 1 year ago

Thanks. I have to clarify though that the earlier logic of doing both together was intentional. The module generally tries to avoid getting information regarding includes and libraries from different sources, as to avoid accidentally using different versions. I believe this is not actually a problem with this singular/plural check. Also there might've been an intention to avoid duplicating the same libs many times which might need some care, but at least it works this way too.