search

Tropfchen / ComfyUI-yaResolutionSelector

Yet Another flexible Resolution Selector node for ComfyUI
GNU General Public License v3.0
10 stars 5 forks source link

decimal aspect ratio #5

Open dryodryo opened 2 months ago

dryodryo commented 2 months ago

Hey, thanks so much for authoring this, the Advanced node is very helpful and almost exactly what I want.

The only issue is that the aspect ratio fields are integer values. Many common aspect ratios are expressed as decimal values. E.g. widescreen cinematic aspect is 2.35:1.

So, in a future update, can you make the width_ratio and height_ratio data types floating points? I could probably do it myself but I don't know Python.

Thanks!

Tropfchen commented 2 months ago

In such case you could use 235:100, or the 47:20 approximation, as due to rounding generated image will not be exactly 2.35:1 anyway, but yeah, i will look into that.

dryodryo commented 2 months ago

Thanks, it's just a minor quality of life thing. Keep up the great work!