search

Trophonix / TradePlus

Easy-to-use, highly configurable trading plugin for Spigot- and Bukkit-based Minecraft servers.
https://www.spigotmc.org/resources/23138/
GNU General Public License v3.0
54 stars 43 forks source link

/trade is crashing bedrock mobile players #92

Closed Skizzles closed 1 year ago

Skizzles commented 1 year ago

https://user-images.githubusercontent.com/30563757/199846062-fa7e6adc-d988-4e03-8a5b-a4cc90e6060b.mov

Seems to be something with the user putting items in "their items", this is using Geyser on a 1.19.2 Purpur Java server.

Trophonix commented 1 year ago

Hmm.. thanks for letting me know. I will look into the part of the code that prevents players from putting items on the wrong side of the trade and see if I can identify something that might be incompatible with bedrock. Im really not experienced with that. Have you had trouble with any other plugins causing problems when a player tries to do something that the plugin prevents (cancelling the event)?

On Thu, Nov 3, 2022, 5:26 PM Skizzles @.***> wrote:

https://user-images.githubusercontent.com/30563757/199846062-fa7e6adc-d988-4e03-8a5b-a4cc90e6060b.mov

Seems to be something with the user putting items in "their items", this is using Geyser on a 1.19.2 Purpur Java server.

— Reply to this email directly, view it on GitHub https://github.com/Trophonix/TradePlus/issues/92, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACW2LWSH4PWE2XYEH3TES5TWGQ33BANCNFSM6AAAAAARWTSG7M . You are receiving this because you are subscribed to this thread.Message ID: @.***>

Skizzles commented 1 year ago

Hmm.. thanks for letting me know. I will look into the part of the code that prevents players from putting items on the wrong side of the trade and see if I can identify something that might be incompatible with bedrock. Im really not experienced with that. Have you had trouble with any other plugins causing problems when a player tries to do something that the plugin prevents (cancelling the event)? … On Thu, Nov 3, 2022, 5:26 PM Skizzles @.> wrote: https://user-images.githubusercontent.com/30563757/199846062-fa7e6adc-d988-4e03-8a5b-a4cc90e6060b.mov Seems to be something with the user putting items in "their items", this is using Geyser on a 1.19.2 Purpur Java server. — Reply to this email directly, view it on GitHub <#92>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACW2LWSH4PWE2XYEH3TES5TWGQ33BANCNFSM6AAAAAARWTSG7M . You are receiving this because you are subscribed to this thread.Message ID: @.>

I have not had many issues tbh, I know most plugins are able to cancel events for bedrock players using geyser/floodgate api.