Fix https://youtu.be/IJ7jau2Cvy4 dupe glitch

Trophonix / TradePlus

Easy-to-use, highly configurable trading plugin for Spigot- and Bukkit-based Minecraft servers.

https://www.spigotmc.org/resources/23138/

GNU General Public License v3.0

54 stars 43 forks source link

Fix https://youtu.be/IJ7jau2Cvy4 dupe glitch #94

Closed zPirroZ3007 closed 1 year ago

zPirroZ3007 commented 1 year ago

Already tested on a debug instance.

This fixes a dupe exploit you can reproduce by following this video (click)

Please consider converting your GUI implementation to some sort of structured library like this one, it is really a mess to read (and debug I suppose) code on this plugin.

Thanks

Trophonix commented 1 year ago

Yeah, I'm going to work on cleaning up the code. I'll consider using a GUI library like the one you linked. Thank you for your quick response to this video! I will also take a look at the checks which are supposed to prevent players from modifying their trade after accepting. I wonder why the trade isn't being updated when they move the item out.