Screenshare Overlapping

Tropix126 / BetterDiscordStuff

Personal repository for hosting code relating to BetterDiscord.

https://tropix126.github.io/BetterDiscordStuff/

MIT License

55 stars 144 forks source link

Screenshare Overlapping #89

Open IRetr0 opened 3 years ago

IRetr0 commented 3 years ago

Screenshot_22

IRetr0 commented 3 years ago

Screenshot_23

bonkmaykrQ commented 3 years ago

Does this only happen with screenshare? There's a snippet in #88 designed to prevent this from happening but I didn't test it with screenshare, only regular calls.

bonkmaykrQ commented 3 years ago

Bug confirmed on Ubuntu 20.04 LTS. Screenshot above was taken from a remote desktop.

I suspect this was caused by #88 and the fix should be to manually set the position of the screenshare window. Easiest way to do that would be to temporarily remove the changes from #88, copy the results (chrome dev tools > copy styles) and apply them in the latest base.css.

bonkmaykrQ commented 3 years ago

After debugging the issue futher it appears that #app-mount > div.app-1q1i1E.da-app > div > div.layers-3iHuyZ.da-layers.layers-3q14ss.da-layers > div > div > div > div > div.chat-3bRxxu.da-chat > div.wrapper-2qzCYF.da-wrapper.normal-1oavYI.video--KPXCT.da-video.theme-dark > div was accidentally given a top margin, reverting it should fix the problem. I've made a pull request to hopefully remove this bug. (see #90)

Screenshot_20201026_150837

bonkmaykrQ commented 3 years ago

Are you still having problems? If not I suggest closing this issue thread.