Trouv / bevy_ecs_ldtk

ECS-friendly ldtk plugin for bevy, leveraging bevy_ecs_tilemap
Other
641 stars 73 forks source link

refactor!: restructure assets module #206

Closed Trouv closed 11 months ago

Trouv commented 1 year ago

The code quality of assets.rs was lacking. It was a bit too large, too public, under-documented, and overly-responsible. This PR makes a variety of changes mostly aimed at improving the assets module without changing core functionality.

This will likely be merged after the 0.8 release, and released in 0.9 instead (between bevy upgrades). This is so users can deal with the breaking changes at their own pace rather than having to deal with them when upgrading their projects to bevy 0.11. Though, the breaking changes here shouldn't affect users much under normal usage.

Non-breaking changes

Breaking changes

BEGIN_COMMIT_OVERRIDE refactor!: LdtkAsset renamed to LdtkProject (#206) refactor!: LdtkProject::project and LdtkLevel::level fields have both been renamed to data (#206) refactor!: All fields of LdtkProject and LdtkLevel are now privatized, and have immutable getter methods (#206) refactor!: LevelMap and TilesetMap type aliases have been removed (#206) refactor!: LdtkAsset and LdtkProject are now exported in new assets module instead of lib.rs (#206) refactor!: asset Loader types are now private (#206) END_COMMIT_OVERRIDE

Trouv commented 1 year ago

Actually, decided to split the world_height stuff into its own PR here: https://github.com/Trouv/bevy_ecs_ldtk/pull/207