Trouv / bevy_ecs_ldtk

ECS-friendly ldtk plugin for bevy, leveraging bevy_ecs_tilemap
Other
641 stars 73 forks source link

ci: upgrade CI to current bevy_github_ci_template and lint more targets/features #208

Closed Trouv closed 1 year ago

Trouv commented 1 year ago

This changes the linting CI drastically to be based off the most recent bevy_github_ci_template. This upgrade includes switching to the actively-maintained dtolnay actions, and implements caching.

This template was updated to have all jobs run against all-targets and all-features as necessary. This begins to resolve a couple of code-review pain-points for me, like having to lint the examples/tests myself.

The template was also updated to have a check job. I imagine this was excluded from the template since checking compilation is implicitly performed by the test job. However, I think it's a good idea to include some basic checks that various feature permutations are OK, since feature selection can greatly impact compilation. For now, this checks the package with no features (without --all-targets, since some of the examples require features), with default features, and with all features.

chore: fix clippy issues for all targets (#208)