feat!: More intuitive default instantiation behavior.

Trouv / bevy_ecs_ldtk

ECS-friendly ldtk plugin for bevy, leveraging bevy_ecs_tilemap

Other

630 stars 74 forks source link

feat!: More intuitive default instantiation behavior. #222

Closed elenakrittik closed 9 months ago

elenakrittik commented 10 months ago

Changes the default behavior to use bundle's struct's Default impl instead of each individual field's.

Solves #119.

[x] I have properly formatted code using cargo fmt.
[x] I have tested the code and documentation i changed by both crafting and running an example and by running cargo test.
[x] I have ran cargo clippy and fixed any issues arising from my changes.

elenakrittik commented 10 months ago

I personally totally share your vision and if breaking changes are for the better, then i'll make them. But at the same time i recognize that there's a plenty of developers with busy schedules and that they would rather prefer to receive bug fixes without the accompanying breaking changes. Though, in case of Bevy's ecosystem, i imagine most people will be fine with breaking changes, or pin bevy-related dependencies to specific versions and upgrade only when they're ready. I'll change this PR a bit later.

elenakrittik commented 10 months ago

Done. Due to removal of backwards compatibility had to add lots of #[derive(Default)]s.

elenakrittik commented 9 months ago

Done, sorry for this simple change taking so long.